Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24636 )
Change subject: IMPALA-8523: Migrate hdfsOpen to builder-based openFile API ...................................................................... Patch Set 7: > Patch Set 3: > > Looks good overall, but I think we should also pass open_options in the ORC > scanner: > > be/src/exec/orc/hdfs-orc-scanner.cc:158 and :261 Thanks, I added the open_options in the ORC scanner as well. Also, made some code/comments more concise and moved the open-file-options-util* files to src/util from src/exec. -- To view, visit http://gerrit.cloudera.org:8080/24636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46d810b19fe7d4859e3c2bcd7568b61fe73408c1 Gerrit-Change-Number: 24636 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 01 Sep 2026 10:08:35 +0000 Gerrit-HasComments: No
