Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24636 )
Change subject: IMPALA-8523: Migrate hdfsOpen to builder-based openFile API ...................................................................... Patch Set 7: (2 comments) Please run exhaustive tests on S3 and Ozone as well http://gerrit.cloudera.org:8080/#/c/24636/7/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24636/7/be/src/exec/orc/hdfs-orc-scanner.cc@158 PS7, Line 158: OpenFileOptions open_options = : BuildOpenFileOptions(scanner_->filename(), THdfsFileFormat::ORC, getLength()); : ScanRange* range = scanner_->scan_node_->AllocateScanRange( : ScanRange::FileInfo{scanner_->filename(), metadata_range->fs(), : split_range->mtime(), split_range->is_encrypted(), : split_range->is_erasure_coded(), open_options}, : length, offset, partition_id, split_range->disk_id(), expected_local, : BufferOpts::ReadInto(reinterpret_cast<uint8_t*>(buf), length, cache_options)); Could we use metadata_range->GetFileInfo? ScanRange* range = scanner_->scan_node_->AllocateScanRange( metadata_range->GetFileInfo(), length, offset, partition_id, split_range->disk_id(), expected_local, BufferOpts::ReadInto(reinterpret_cast<uint8_t*>(buf), length, cache_options)); http://gerrit.cloudera.org:8080/#/c/24636/7/be/src/exec/orc/hdfs-orc-scanner.cc@263 PS7, Line 263: OpenFileOptions open_options = : BuildOpenFileOptions(filename(), THdfsFileFormat::ORC, file_length); : ScanRange* scan_range = scan_node_->AllocateScanRange( : ScanRange::FileInfo{filename(), metadata_range_->fs(), split_range->mtime(), : split_range->is_encrypted(), split_range->is_erasure_coded(), open_options}, : range.length_, range.offset_, partition_id, split_range->disk_id(), : col_range_local, BufferOpts(split_range->cache_options())); Similarly to above: ScanRange* scan_range = scan_node_->AllocateScanRange( metadata_range_->GetFileInfo(), range.length_, range.offset_, partition_id, split_range->disk_id(), col_range_local, BufferOpts(split_range->cache_options())); -- To view, visit http://gerrit.cloudera.org:8080/24636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46d810b19fe7d4859e3c2bcd7568b61fe73408c1 Gerrit-Change-Number: 24636 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 01 Sep 2026 17:48:48 +0000 Gerrit-HasComments: Yes
