Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24426 )

Change subject: IMPALA-14601: Support HBO for JoinNode cardinality
......................................................................


Patch Set 31:

Thanks for the review! I found the JoinNode key string is also missing LIMIT. 
Fixed this and did some refactor:

- Added the missing LIMIT in the key string.
- Extracted the code of adding LIMIT to PlanNode so future node types won't 
miss LIMIT.
- Renamed the Key string fields to use camel names.
- Removed trailing "|" in the key string.
- Added FE tests for LIMIT.


--
To view, visit http://gerrit.cloudera.org:8080/24426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4
Gerrit-Change-Number: 24426
Gerrit-PatchSet: 31
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Sun, 06 Sep 2026 01:25:50 +0000
Gerrit-HasComments: No

Reply via email to