Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 24: (1 comment) http://gerrit.cloudera.org:8080/#/c/24426/24/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/24/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@191 PS24, Line 191: if (sourceExprs.size() != 1 || !(sourceExprs.get(0) instanceof SlotRef)) return null; > A materialized expression can lose its operand qualifiers here. `SortInfo` The coalesce(...) tests in PS31 and 24592 PS9 cover the case I reported. I don't have a concrete cycle case, so I'm fine leaving out the guard. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 24 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 06 Sep 2026 07:24:43 +0000 Gerrit-HasComments: Yes
