Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24682 )
Change subject: IMPALA-15310: Finalize REST catalog INSERT ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/24682/10/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/24682/10/common/thrift/CatalogService.thrift@316 PS10, Line 316: the coordinator's own frontend and never reaches the CatalogService > We could have a precondition check for this in CatalogOpExecutor. Thanks for the review! Added the check in CatalogOpExecutor in PS11, before the table lookup. http://gerrit.cloudera.org:8080/#/c/24682/10/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/24682/10/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@321 PS10, Line 321: INSERT_INTO > Will we need this after IMPALA-15320? Yes, we still need to distinguish INSERT INTO from other writes. IMPALA-15320 moves the checks into checkTableCapability(); it does not add support for the other REST write operations. Added a comment explaining this in PS11. http://gerrit.cloudera.org:8080/#/c/24682/10/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@432 PS10, Line 432: ensureRestCatalogInsertEnabled(table); > This can throw a misleading exception when ensureNonInsertDmlSupported() is Fixed in PS11. The non-INSERT check now reports the unsupported operation directly. http://gerrit.cloudera.org:8080/#/c/24682/10/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java: http://gerrit.cloudera.org:8080/#/c/24682/10/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java@38 PS10, Line 38: tables stored in HadoopCatalog > Not added by this change, but this is a stale comment. Changed HadoopCatalog to REST catalog in the comment in PS11. http://gerrit.cloudera.org:8080/#/c/24682/10/fe/src/main/java/org/apache/impala/util/DebugUtils.java File fe/src/main/java/org/apache/impala/util/DebugUtils.java: http://gerrit.cloudera.org:8080/#/c/24682/10/fe/src/main/java/org/apache/impala/util/DebugUtils.java@62 PS10, Line 62: catalogd_ > Not it can fire in the coordinator as well, i.e. probably we should drop th Renamed it to iceberg_commit and updated the tests in PS11. http://gerrit.cloudera.org:8080/#/c/24682/10/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/24682/10/tests/custom_cluster/test_iceberg_rest_catalog.py@98 PS10, Line 98: server.stop_rest_server() > Now that stop_rest_server can raise an excpetion, this could be in a try-ex Fixed in PS11. Cleanup now tries to stop every server and always runs the parent teardown. A shutdown error also won't hide the original setup error. -- To view, visit http://gerrit.cloudera.org:8080/24682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d17216fb8d12e5bd007b93cb9b3bc153438213b Gerrit-Change-Number: 24682 Gerrit-PatchSet: 10 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 07 Sep 2026 19:33:08 +0000 Gerrit-HasComments: Yes
