Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24682 )
Change subject: IMPALA-15310: Finalize REST catalog INSERT ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/24682/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24682/11//COMMIT_MSG@42 PS11, Line 42: Earlier patch sets: > nit: no need to call out "Earlier patch sets" and "Review follow-up". Only Thanks, fixed in PS12. The Testing section now describes only the current patch set. http://gerrit.cloudera.org:8080/#/c/24682/11/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/24682/11/common/thrift/CatalogService.thrift@314 PS11, Line 314: // Identifies the metadata provider that owns coordinator-side Iceberg DML > This is a semantic overload: one struct now means two different destination Thanks for the review. PS12 uses a dedicated TIcebergDmlFinalizeRequest for coordinator-side finalization. TUpdateCatalogRequest remains on the CatalogD route. http://gerrit.cloudera.org:8080/#/c/24682/11/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/24682/11/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@322 PS11, Line 322: INSERT_INTO, > OperationType is a table-access-capability axis: READ, WRITE, ANY. The comm Fixed in PS12. OperationType is back to READ/WRITE/ANY, and ensureTableWriteSupported() now receives the INSERT context. http://gerrit.cloudera.org:8080/#/c/24682/11/java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java File java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/24682/11/java/iceberg-rest-catalog-test/src/main/java/org/apache/iceberg/rest/IcebergRestCatalogTest.java@148 PS11, Line 148: private void prepareWriteTestTable(Catalog catalog, String tableName) > The test table creation should live in the test files. The test server is a Fixed in PS12. The Python fixture now creates and drops the test table through the REST API, and the Java server is generic again. -- To view, visit http://gerrit.cloudera.org:8080/24682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d17216fb8d12e5bd007b93cb9b3bc153438213b Gerrit-Change-Number: 24682 Gerrit-PatchSet: 11 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 08 Sep 2026 17:14:18 +0000 Gerrit-HasComments: Yes
