Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24940 )

Change subject: IMPALA-11917: Upgrade to GCC 15 and LLVM 22
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24940/18/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

http://gerrit.cloudera.org:8080/#/c/24940/18/be/src/exprs/scalar-fn-call.cc@344
PS18, Line 344:       if (col_type == TYPE_BOOLEAN or col_type == TYPE_TINYINT
> Getting rid of typed pointers allowed cleaning up the control flow a bit. I
I'd be ok returning this section to aarch64-only, and eventually following up 
with efforts to move more of our allocations to 16-byte alignment.



--
To view, visit http://gerrit.cloudera.org:8080/24940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dda730fa98ebe3825969265627a560b0c3095f9
Gerrit-Change-Number: 24940
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Mon, 05 Oct 2026 15:50:06 +0000
Gerrit-HasComments: Yes

Reply via email to