Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24988 )
Change subject: IMPALA-15443: Fix Parquet stats of widened INT32/INT64/FLOAT columns ...................................................................... Patch Set 2: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24988/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24988/1//COMMIT_MSG@28 PS1, Line 28: ColumnStatsReader::ReadFromStringsBatch(), an unrolled variant of : ReadFromString(). It had more bugs that did not need widening: after : an all-NULL page, e.g. in files sorted NULLS FIRST, it left up to 7 : values at the end of the span of pages undecoded, whic > I don't understand the scope of this second issue: which function has it an Rephrased commit message. Yes, it was buggy earlier, added tests with NULL pages. http://gerrit.cloudera.org:8080/#/c/24988/1/be/src/exec/parquet/parquet-column-stats.cc File be/src/exec/parquet/parquet-column-stats.cc: http://gerrit.cloudera.org:8080/#/c/24988/1/be/src/exec/parquet/parquet-column-stats.cc@337 PS1, Line 337: > Do we actually need this fast track path? 2 values per page doesn't look th It contained even more bugs, so I (Opus) removed it. http://gerrit.cloudera.org:8080/#/c/24988/1/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_widened_columns.test File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_widened_columns.test: http://gerrit.cloudera.org:8080/#/c/24988/1/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_widened_columns.test@331 PS1, Line 331: : : > I don't understand a the logic behind choosing these values. Shouldnát we d Removed these tests. -- To view, visit http://gerrit.cloudera.org:8080/24988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia39297e906802ed698178943b9c60b79eb905cdb Gerrit-Change-Number: 24988 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 15:50:07 +0000 Gerrit-HasComments: Yes
