Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24988 )
Change subject: IMPALA-15443: Fix Parquet stats of widened INT32/INT64/FLOAT columns ...................................................................... Patch Set 2: (2 comments) Didn't dive into the test, the new code looks ok to me - I still struggle a bit with the old code though. http://gerrit.cloudera.org:8080/#/c/24988/2/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24988/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@1214 PS2, Line 1214: minmax_filter_fast_code_path maybe this could be removed in Impala 5.0? I don't see why this worth its own query option. http://gerrit.cloudera.org:8080/#/c/24988/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@1225 PS2, Line 1225: CollectSkippedPageRangesForSortedColumn Is this really useful? This still looks to me like doing O(log n) lookup after doing O(n) Thrift parsing - it is hard to imagine more than marginal win. This could be more interesting if we were caching parsed Parquet metadata and column indexes, so the scanner could jump to the right page without parsing the whole footer. -- To view, visit http://gerrit.cloudera.org:8080/24988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia39297e906802ed698178943b9c60b79eb905cdb Gerrit-Change-Number: 24988 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Oct 2026 09:21:55 +0000 Gerrit-HasComments: Yes
