Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24988 )
Change subject: IMPALA-15443: Fix Parquet stats of widened INT32/INT64/FLOAT columns ...................................................................... Patch Set 2: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24988/2/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24988/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@1214 PS2, Line 1214: minmax_filter_fast_code_path > maybe this could be removed in Impala 5.0? I don't see why this worth its o How about doing it in a follow-up patch, so this fix remain backportable to old branches? http://gerrit.cloudera.org:8080/#/c/24988/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@1225 PS2, Line 1225: CollectSkippedPageRangesForSortedColumn > Is this really useful? This still looks to me like doing O(log n) lookup af I can do it in the follow-up patch for the query option removal. -- To view, visit http://gerrit.cloudera.org:8080/24988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia39297e906802ed698178943b9c60b79eb905cdb Gerrit-Change-Number: 24988 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Oct 2026 12:19:31 +0000 Gerrit-HasComments: Yes
