Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 )
Change subject: IMPALA-6299: Modify IRBuilder to use LLVM's CPU features ...................................................................... Patch Set 2: I made the mistake of only looking at the code that was changed. I think this is missing some updates to codegen functions. E.g. there's a CpuInfo::IsSupported(CpuInfo::AVX2) in FilterContext::CodegenInsert() that should be converted to the new API. I did a quick grep and I think that might be the only place, but you should also verify that we don't need to update any more callsites of CpuInfo::IsSupported -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Jul 2018 16:50:15 +0000 Gerrit-HasComments: No
