Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 )
Change subject: IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/10979/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10979/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-6299: Use LlvmCodeGen's internal list of white-li > Use LlvmCodeGen's internal list of white-listed CPU attributes for handcraf Done http://gerrit.cloudera.org:8080/#/c/10979/5//COMMIT_MSG@10 PS5, Line 10: determine the validity of certain : instructions > to emit intrinsics Done http://gerrit.cloudera.org:8080/#/c/10979/5/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/10979/5/be/src/codegen/llvm-codegen-test.cc@116 PS5, Line 116: EnableCodeGenCPUFeat > nit: EnableCodeGenCPUFeature Done -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jul 2018 20:10:54 +0000 Gerrit-HasComments: Yes
