Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10979 )
Change subject: IMPALA-6299: Modify IRBuilder to use LLVM's CPU features ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/10979/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10979/2//COMMIT_MSG@10 PS2, Line 10: while nit: to http://gerrit.cloudera.org:8080/#/c/10979/2//COMMIT_MSG@10 PS2, Line 10: certian nit:typo http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen.h@737 PS2, Line 737: current_cpu_attrs_ > Maybe enabled_cpu_attrs_? I agree with Tim http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen.cc@252 PS2, Line 252: auto cpu_flag_it = cpu_flag_mappings_.find(CpuInfo::SSE4_2); : DCHECK(cpu_flag_it != cpu_flag_mappings_.end()); : if (current_cpu_attrs_.find(cpu_flag_it->second) != current_cpu_attrs_.end( can we use IsCPUFeatureEnabled() here? http://gerrit.cloudera.org:8080/#/c/10979/2/be/src/codegen/llvm-codegen.cc@1581 PS2, Line 1581: auto cpu_flag_it = cpu_flag_mappings_.find(CpuInfo::SSE4_2); : DCHECK(cpu_flag_it != cpu_flag_mappings_.end()); : if (current_cpu_attrs_.find(cpu_flag_it->second) != current_cpu_attrs_.end( same here, IsCPUFeatureEnabled can be used -- To view, visit http://gerrit.cloudera.org:8080/10979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f Gerrit-Change-Number: 10979 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Jul 2018 20:40:42 +0000 Gerrit-HasComments: Yes
