Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11045 )
Change subject: IMPALA-6335. Allow most shell tests to run in parallel ...................................................................... Patch Set 2: (2 comments) Thanks for the change! I had problems in the past with running multiple shells at the same time and forgetting the history of one them - this will give a tool to avoid this. http://gerrit.cloudera.org:8080/#/c/11045/2/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/11045/2/tests/custom_cluster/test_shell_interactive_reconnect.py@35 PS2, Line 35: p = ImpalaShell("--history_file=/dev/null") Wouldn't it be better to put this into setup/teardown, so that it cannot be forgotten in new tests? For example https://gerrit.cloudera.org/#/c/10992/ contains a new test, and merging the two changes may lead to side effects. http://gerrit.cloudera.org:8080/#/c/11045/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/11045/2/tests/shell/test_shell_interactive.py@51 PS2, Line 51: self.history_file = tempfile.mktemp() I would prefer to set IMPALA_HISTFILE to /dev/null by default and use NamedTemporaryFile(delete=True) in the few tests that read the history. This could probably make interactive tests a little bit faster. -- To view, visit http://gerrit.cloudera.org:8080/11045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1da5739276e63a50590dfcb2b050703f8e35fec7 Gerrit-Change-Number: 11045 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Jul 2018 13:20:33 +0000 Gerrit-HasComments: Yes
