Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11045 )

Change subject: IMPALA-6335. Allow most shell tests to run in parallel
......................................................................


Patch Set 5:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/11045/5/shell/impala_shell_config_defaults.py
File shell/impala_shell_config_defaults.py:

http://gerrit.cloudera.org:8080/#/c/11045/5/shell/impala_shell_config_defaults.py@27
PS5, Line 27: H
flake8: E126 continuation line over-indented for hanging indent


http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py@49
PS5, Line 49: def tmp_history_file(request):
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py@66
PS5, Line 66:
flake8: E701 multiple statements on one line (colon)


http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py@275
PS5, Line 275:
flake8: E703 statement ends with a semicolon


http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py@276
PS5, Line 276:
flake8: E703 statement ends with a semicolon


http://gerrit.cloudera.org:8080/#/c/11045/5/tests/shell/test_shell_interactive.py@277
PS5, Line 277:
flake8: E703 statement ends with a semicolon



--
To view, visit http://gerrit.cloudera.org:8080/11045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1da5739276e63a50590dfcb2b050703f8e35fec7
Gerrit-Change-Number: 11045
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 02:47:06 +0000
Gerrit-HasComments: Yes

Reply via email to