Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11045 )

Change subject: IMPALA-6335. Allow most shell tests to run in parallel
......................................................................


Patch Set 5:

(1 comment)

Fixed some flake8s, though tries to meet half-way between consistency with 
existing code and making flake8 happy

http://gerrit.cloudera.org:8080/#/c/11045/4/shell/impala_shell_config_defaults.py
File shell/impala_shell_config_defaults.py:

http://gerrit.cloudera.org:8080/#/c/11045/4/shell/impala_shell_config_defaults.py@27
PS4, Line 27: H
> flake8: E126 continuation line over-indented for hanging indent
hmm, do we not do +4 indentation in Python for hanging indents?



--
To view, visit http://gerrit.cloudera.org:8080/11045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1da5739276e63a50590dfcb2b050703f8e35fec7
Gerrit-Change-Number: 11045
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 02:46:24 +0000
Gerrit-HasComments: Yes

Reply via email to