Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 )
Change subject: IMPALA-6709: Simplify tests that copy local files to tables ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11127/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11127/1//COMMIT_MSG@17 PS1, Line 17: : Change-Id: Ie00a4561825facf8abe2e8e74a6b6e93194f416f : > A function that expects the create statement as argument could help in othe Thanks for the suggestion. I added the create_table_and_copy_files() function. http://gerrit.cloudera.org:8080/#/c/11127/1/tests/common/test_parquet.py File tests/common/test_parquet.py: http://gerrit.cloudera.org:8080/#/c/11127/1/tests/common/test_parquet.py@24 PS1, Line 24: > As this only works for Parquet files I would prefer include "parquet" in th Done http://gerrit.cloudera.org:8080/#/c/11127/1/tests/common/test_parquet.py@31 PS1, Line 31: > This is the nittiest of nits, but I am learning python: Done http://gerrit.cloudera.org:8080/#/c/11127/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11127/1/tests/query_test/test_scanners.py@a318 PS1, Line 318: : > A note of caution here. There is a distinction between: Yeah I only used CREATE TABLE LIKE when this behaviour seemed irrelevant to the purpose of the test. -- To view, visit http://gerrit.cloudera.org:8080/11127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie00a4561825facf8abe2e8e74a6b6e93194f416f Gerrit-Change-Number: 11127 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Aug 2018 16:22:40 +0000 Gerrit-HasComments: Yes
