Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11127 )

Change subject: IMPALA-6709: Simplify tests that copy local files to tables
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11127/1/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

http://gerrit.cloudera.org:8080/#/c/11127/1/tests/query_test/test_scanners.py@a318
PS1, Line 318:
             :
> Yeah I only used CREATE TABLE LIKE when this behaviour seemed irrelevant to
I was confused by some of our documentation that indicates TINYINT/SMALLINT are 
not interpreted correctly ( 
https://github.com/apache/impala/blob/master/docs/topics/impala_create_table.xml#L1087
 ). It looks like this was fixed in IMPALA-5052. I'll look into a filing a doc 
bug.



--
To view, visit http://gerrit.cloudera.org:8080/11127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00a4561825facf8abe2e8e74a6b6e93194f416f
Gerrit-Change-Number: 11127
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Aug 2018 17:51:01 +0000
Gerrit-HasComments: Yes

Reply via email to