Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11127 )
Change subject: IMPALA-6709: Simplify tests that copy local files to tables ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11127/2/tests/common/test_files.py File tests/common/test_files.py: http://gerrit.cloudera.org:8080/#/c/11127/2/tests/common/test_files.py@1 PS2, Line 1: # Licensed to the Apache Software Foundation (ASF) under one About the name of the file: test_* is a conventional way to name files that actually contain tests. This is a file with utility functions, so it would be better to give it a different name. http://gerrit.cloudera.org:8080/#/c/11127/2/tests/query_test/test_parquet_stats.py File tests/query_test/test_parquet_stats.py: http://gerrit.cloudera.org:8080/#/c/11127/2/tests/query_test/test_parquet_stats.py@64 PS2, Line 64: / I would prefer to start these without '/'. + $IMPALA_HOME/testdata/data could be assumed as base similarly to create_table_from_parquet - the minority of files that do not reside there could use .. in their address. http://gerrit.cloudera.org:8080/#/c/11127/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11127/2/tests/query_test/test_scanners.py@307 PS2, Line 307: self.clien Just an idea to make these shorter: this functions could be ImpalaTestSuite member functions, so this argument could be moved to the front as "self.". -- To view, visit http://gerrit.cloudera.org:8080/11127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie00a4561825facf8abe2e8e74a6b6e93194f416f Gerrit-Change-Number: 11127 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Aug 2018 20:35:01 +0000 Gerrit-HasComments: Yes
