Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml File docs/topics/impala_timestamp.xml: http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@180 PS1, Line 180: + INTERVAL <varname>n-hours</varname></codeph> can be affected Daylight Saving Time, which nit: missing 'by'? http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@193 PS1, Line 193: Configuring custom time zones: I think that it would be better to move custom timezone databases/aliases to a separate topic/file if possible, as only probably only a small subset of users will be interested in these. http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333 PS1, Line 333: values the same way it stores : without any adjustment. This part of the sentence is not clear for me. http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367 PS1, Line 367: turned off by : default to avoid performance overhead I think that this was true before 3.1, but in 3.1 the conversion became much faster, so the main reason is compatibility: the result of an existing non-buggy query should not change in a minor version. I think that IMPALA-3307 could be mentioned as the reason for speedup. convert_legacy_hive_parquet_utc_timestamps is known by users to be extremely slow, so the change could be highlighted to make it clear that this a much small issue now. -- To view, visit http://gerrit.cloudera.org:8080/11946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a Gerrit-Change-Number: 11946 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 19 Nov 2018 14:36:37 +0000 Gerrit-HasComments: Yes