Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml File docs/topics/impala_timestamp.xml: http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367 PS1, Line 367: turned off by : default to avoid performance overhead > Done I still think that the improvement should mentioned, e.g "Before 3.1, this option had severe impact on multi-threaded performance. The new timezone implementation in 3.1 eliminated most of the overhead." One reason why I would recommend switching this on is that 3.2 will include int64 encoded timestamps, where timezone handling is no longer influenced by this flag, but decided by metadate in the .parquet file. This means that if this flag is turned off, then int64 and int96 timestamps will behave differently. -- To view, visit http://gerrit.cloudera.org:8080/11946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a Gerrit-Change-Number: 11946 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Ivanfi <zi+ger...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 16:03:49 +0000 Gerrit-HasComments: Yes