Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 )
Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml File docs/topics/impala_timestamp.xml: http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@180 PS1, Line 180: + INTERVAL <varname>n-hours</varname></codeph> can be affected Daylight Saving Time, which > nit: missing 'by'? Done http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@193 PS1, Line 193: Configuring custom time zones: > I agree. Done http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@193 PS1, Line 193: Configuring custom time zones: > I think that it would be better to move custom timezone databases/aliases t Done http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@272 PS1, Line 272: 2017c > Instead of '2017c' probably we should use a more generic directory name her Done http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@333 PS1, Line 333: values the same way it stores : without any adjustment. > This part of the sentence is not clear for me. Hive reads and writes TIMESTAMP values without converting with respect to time zones. Better? http://gerrit.cloudera.org:8080/#/c/11946/1/docs/topics/impala_timestamp.xml@367 PS1, Line 367: turned off by : default to avoid performance overhead > Turning on '-convert_legacy_hive_parquet_utc_timestamps' still has a cost, Done -- To view, visit http://gerrit.cloudera.org:8080/11946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id400cda5a1be321063d17e0ee6337e92a5da732a Gerrit-Change-Number: 11946 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Nov 2018 03:15:57 +0000 Gerrit-HasComments: Yes
