Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 )
Change subject: IMPALA-7842: Expose physical plan for unit testing ...................................................................... Patch Set 5: (5 comments) Bharath, thanks much for the review. Addressed your comments. http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@181 PS4, Line 181: > remove Done http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@186 PS4, Line 186: // The query context. : protected final TQueryCtx queryCtx_; : // The explain string built from the query plan. : protected final StringBuilder expla > Please add one-liner docs for these. Done http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@217 PS4, Line 217: public List<PlanFragment> getPlan() { return plan_; } > nit: single line Done http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@1220 PS4, Line 1220: > ? Done http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/Frontend.java@1221 PS4, Line 1221: : : /** : * Create a TExecRequest for the query and query context provided in the plan : * context. Optionally fills in the EXP > Not sure if this applies given the current signature change. Done -- To view, visit http://gerrit.cloudera.org:8080/11920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c615dbc1d14685a6966c5ca7538777cdc80b74d Gerrit-Change-Number: 11920 Gerrit-PatchSet: 5 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Dec 2018 01:47:32 +0000 Gerrit-HasComments: Yes
