Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 )
Change subject: IMPALA-7842: Expose physical plan for unit testing ...................................................................... Patch Set 7: (1 comment) Bharath, thanks for the additional review. Corrected the comment you identified. Rebased on the latest master. http://gerrit.cloudera.org:8080/#/c/11920/6/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11920/6/fe/src/main/java/org/apache/impala/service/Frontend.java@1225 PS6, Line 1225: Fills in the EXPLAIN string and option > I think the explain string is not optional whereas the thrift plan is? Done -- To view, visit http://gerrit.cloudera.org:8080/11920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c615dbc1d14685a6966c5ca7538777cdc80b74d Gerrit-Change-Number: 11920 Gerrit-PatchSet: 7 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 21:11:04 +0000 Gerrit-HasComments: Yes
