Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11920 )
Change subject: IMPALA-7842: Expose physical plan for unit testing ...................................................................... Patch Set 6: (3 comments) Bharath, thanks for the review. Addressed the comments overlooked in the previous pass. http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@171 PS4, Line 171: e > nit: remove space Done http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java File fe/src/test/java/org/apache/impala/planner/CardinalityTest.java: http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@36 PS4, Line 36: PlannerTestBase > Do we need to rebase this on top of the Analysis/Query fixture changes? Good point. The fixture handles only analysis and rewrites. We should extend it for the full plan case as well. I'll do this as s separate patch in which I'll also modify some of the other tests to use the fixture. http://gerrit.cloudera.org:8080/#/c/11920/4/fe/src/test/java/org/apache/impala/planner/CardinalityTest.java@119 PS4, Line 119: / : protected void verifyCardinality(String query, long > Not sure I got this, where is the deep copy? Done -- To view, visit http://gerrit.cloudera.org:8080/11920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c615dbc1d14685a6966c5ca7538777cdc80b74d Gerrit-Change-Number: 11920 Gerrit-PatchSet: 6 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 00:31:48 +0000 Gerrit-HasComments: Yes
