Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 )
Change subject: IMPALA-7924: Generate Thrift 11 Python Code ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks! Only minor stuff from me. http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@159 PS1, Line 159: message("Using Thrift 11 compiler: ${THRIFT_COMPILER}") THRIFT11_COMPILER here, probably. http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@180 PS1, Line 180: set(THRIFT11_PYTHON_ARGS ${THRIFT_INCLUDE_DIR_OPTION} -r --gen py -o ) : set(THRIFT11_PYTHON_ARGS ${THRIFT11_PYTHON_ARGS} ${THRIFT11_PYTHON_OUTPUT_DIR}) Very minor: you can probably use "\" to do line continuation or just stuff this in a single line and ignore character limit. It's a bit hard to parse that this is just "+=" effectively. https://cmake.org/cmake/help/v3.0/manual/cmake-language.7.html#quoted-argument -- To view, visit http://gerrit.cloudera.org:8080/12036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3432c3e29d28ec3ef6a0a22156a18910f511fed0 Gerrit-Change-Number: 12036 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 18:12:55 +0000 Gerrit-HasComments: Yes
