Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 )
Change subject: IMPALA-7924: Generate Thrift 11 Python Code ...................................................................... Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@125 PS1, Line 125: the double word http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@128 PS1, Line 128: this method should be removed. Can you mention IMPALA-7825 here? http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@140 PS1, Line 140: FIL_WE Are FIL and FIL_WE magic strings in CMake? Otherwise, can you find more descriptive names? http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@142 PS1, Line 142: unqiue typo -- To view, visit http://gerrit.cloudera.org:8080/12036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3432c3e29d28ec3ef6a0a22156a18910f511fed0 Gerrit-Change-Number: 12036 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Dec 2018 19:24:44 +0000 Gerrit-HasComments: Yes
