Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12036 )
Change subject: IMPALA-7924: Generate Thrift 11 Python Code ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt File common/thrift/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@125 PS1, Line 125: the > double word Done http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@128 PS1, Line 128: this method should be removed. > Can you mention IMPALA-7825 here? Done http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@140 PS1, Line 140: FIL_WE > Are FIL and FIL_WE magic strings in CMake? Otherwise, can you find more des No they aren't. Changed to THRIFT_FILE and THRIFT_FILE_WE. The WE stands for 'without extension', updated the comments to reflect that. These variables were copied from the function THRIFT_GEN so I changed the variables names there to make it easier to read too. http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@142 PS1, Line 142: unqiue > typo Done http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@159 PS1, Line 159: message("Using Thrift 11 compiler: ${THRIFT_COMPILER}") > THRIFT11_COMPILER here, probably. Done http://gerrit.cloudera.org:8080/#/c/12036/1/common/thrift/CMakeLists.txt@180 PS1, Line 180: set(THRIFT11_PYTHON_ARGS ${THRIFT_INCLUDE_DIR_OPTION} -r --gen py -o ) : set(THRIFT11_PYTHON_ARGS ${THRIFT11_PYTHON_ARGS} ${THRIFT11_PYTHON_OUTPUT_DIR}) > Very minor: you can probably use "\" to do line continuation or just stuff Done -- To view, visit http://gerrit.cloudera.org:8080/12036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3432c3e29d28ec3ef6a0a22156a18910f511fed0 Gerrit-Change-Number: 12036 Gerrit-PatchSet: 1 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Jan 2019 14:14:06 +0000 Gerrit-HasComments: Yes
