Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12443 )

Change subject: IMPALA-7935: Disable /catalog_object endpoint when 
local_catalog_mode is enabled.
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-7935: Disable /catalog_object endpoint when
           : local_catalog_mode is enabled.
nit: Try to fit it in a single line. Something like

<jira>: Disable... endpoint in local catalog mode


http://gerrit.cloudera.org:8080/#/c/12443/1//COMMIT_MSG@10
PS1, Line 10: Remove hyperlinks pointing to the /catalog_object endpoints
            : when local_catalog_mode is enabled.
Mention that getTCatalogObject() is not supported in LocalCatalog mode since 
the metadata is partially fetched on demand?


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc
File be/src/service/impala-http-handler.cc:

http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@103
PS1, Line 103:   webserver->RegisterUrlCallback("/catalog_object", 
"catalog_object.tmpl",
             :       MakeCallback(this, 
&ImpalaHttpHandler::CatalogObjectsHandler), false);
Don't think there is any value in defining this end point when we don't support 
it in local_catalog mode.


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@544
PS1, Line 544:       table_obj.AddMember("use_local_catalog", 
FLAGS_use_local_catalog,
             :           document->GetAllocator());
don't think we need to pass this. We can infer the same depending on whether 
fqtn is set or not and we set it only in the local catalog mode.


http://gerrit.cloudera.org:8080/#/c/12443/1/be/src/service/impala-http-handler.cc@557
PS1, Line 557:   Webserver::ArgumentMap::const_iterator object_type_arg = 
args.find("object_type");
DCHECK !use_local_catalog?


http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py
File tests/custom_cluster/test_local_catalog.py:

http://gerrit.cloudera.org:8080/#/c/12443/1/tests/custom_cluster/test_local_catalog.py@348
PS1, Line 348:   assert '<a 
href="catalog_object?object_type=TABLE&object_name='\
             :         not in impalad.service.read_debug_webpage('/catalog')
Instead I think we should check that there is no handler for /catalog_object on 
the coordinator (after disabling the end point like I mentioned elsewhere).



--
To view, visit http://gerrit.cloudera.org:8080/12443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c
Gerrit-Change-Number: 12443
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 23:24:18 +0000
Gerrit-HasComments: Yes

Reply via email to