Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )
Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@103 PS4, Line 103: if(!FLAGS_use_local_catalog) { > I think you missed the comment part. Add a quick comment? Done http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@541 PS4, Line 541: Value table_obj(kObjectType); > Is this needed? The template file uses fqtn only when use_local_catalog is Yes, fqtn is only needed to call the /catalog_obj endpoint. http://gerrit.cloudera.org:8080/#/c/12443/4/be/src/service/impala-http-handler.cc@549 PS4, Line 549: table_obj.AddMember("name", table_name, document->GetAllocator()); : Value use_local_catalog(FLAGS_use_local_catalog); : table_obj.AddMember("use_loca > Why this? This is needed because, mushtashe templates seem to not recognize variables in parent scope. Hence, it is needed to add the local_catalog variable at both Databases and Tables level to render two different parts of the template. -- To view, visit http://gerrit.cloudera.org:8080/12443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c Gerrit-Change-Number: 12443 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Mar 2019 03:14:49 +0000 Gerrit-HasComments: Yes
