Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12443 )
Change subject: IMPALA-7935: Disable /catalog_object in local catalog mode. ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/12443/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/12443/3/be/src/service/impala-http-handler.cc@100 PS3, Line 100: if(!FLAGS_use_local_catalog) nit: we generally use braces for multiline if blocks. if (condition) { ..... } Add a comment why we disable this end-point? http://gerrit.cloudera.org:8080/#/c/12443/3/be/src/service/impala-http-handler.cc@540 PS3, Line 540: if(!FLAGS_use_local_catalog){ Add a comment that this creates hrefs for /catalog_object which is disabled in local catalog mode? http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl File www/catalog.tmpl: http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl@42 PS3, Line 42: {{^fqtn}} Use 2 space formatting for nested blocks to be consistent with rest of the file. (multiple places) http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl@45 PS3, Line 45: ?fqtn This works as expected right? I see the upstream docs has something like {{#fqtn?}} {{/fqtn}} https://mustache.github.io/mustache.5.html http://gerrit.cloudera.org:8080/#/c/12443/3/www/catalog.tmpl@126 PS3, Line 126: <div class="panel-heading"> : <a href='catalog_object?object_type=DATABASE&object_name={{name}}' id='{{name}}'> : <h2 class="panel-title">{{name}} : <span class="pull-right">{{num_tables}} table(s)</span></h2> : </a> Just stumbled upon this We probably need to remove this too? In which case we need to pass the "local_catalog" flag. sorry for the confusion. You may have to redo that part. -- To view, visit http://gerrit.cloudera.org:8080/12443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia04797b32964c2edaa2e860dcf510d6f9cccd81c Gerrit-Change-Number: 12443 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Feb 2019 19:20:02 +0000 Gerrit-HasComments: Yes
