Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12543 )
Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning ...................................................................... Patch Set 3: (1 comment) Looks good, just had the one question about the Hive thrift. http://gerrit.cloudera.org:8080/#/c/12543/3/common/thrift/hive-1-api/TCLIService.thrift File common/thrift/hive-1-api/TCLIService.thrift: PS3: This is a copy of the Hive thrift so it might cause confusion if we diverge. -- To view, visit http://gerrit.cloudera.org:8080/12543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If215f16a636008757ceb439edbd6900a1be88c59 Gerrit-Change-Number: 12543 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Feb 2019 06:12:18 +0000 Gerrit-HasComments: Yes
