Hello Philip Zeyliger, Tim Armstrong, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12543
to look at the new patch set (#6).
Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add
warning
......................................................................
IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning
IMPALA-7694 added a field in the middle of the Metrics.TUnit enum, which
broke backwards compatibility with profiles that had been written by
older versions of Impala. This change fixes the ordering by moving the
field to the end of the enum.
Additionally, it adds a warning to the top of all Thrift files that are
part of the binary profile format, and an note of caution to the main
definition in RuntimeProfile.thrift.
This change also fixes the order of all enums in our Thrift files to
make errors like this less likely in the future.
Change-Id: If215f16a636008757ceb439edbd6900a1be88c59
---
M common/thrift/BackendGflags.thrift
M common/thrift/CatalogObjects.thrift
M common/thrift/DataSinks.thrift
M common/thrift/ExecStats.thrift
M common/thrift/Exprs.thrift
M common/thrift/ExternalDataSource.thrift
M common/thrift/Frontend.thrift
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M common/thrift/JniCatalog.thrift
M common/thrift/LineageGraph.thrift
M common/thrift/Logging.thrift
M common/thrift/Metrics.thrift
M common/thrift/Partitions.thrift
M common/thrift/PlanNodes.thrift
M common/thrift/RuntimeProfile.thrift
M common/thrift/StatestoreService.thrift
M common/thrift/Status.thrift
M common/thrift/Types.thrift
M common/thrift/beeswax.thrift
20 files changed, 482 insertions(+), 444 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/12543/6
--
To view, visit http://gerrit.cloudera.org:8080/12543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If215f16a636008757ceb439edbd6900a1be88c59
Gerrit-Change-Number: 12543
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
