Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12543 )
Change subject: IMPALA-8234: Fix ordering of Thrift enum, fix enum values, add warning ...................................................................... Patch Set 5: (2 comments) One small thing. Otherwise, I'm ready to approve http://gerrit.cloudera.org:8080/#/c/12543/5/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/12543/5/common/thrift/ImpalaService.thrift@61 PS5, Line 61: // > 1: executes on at most that many nodes at any point in time (ie there can be : // more nodes than numNodes with plan fragments for this query but at most : // numNodes would be active at any point in time) : // Constants (NUM_NODES_ALL NUM_NODES_ALL_RACKS) are defined in JavaConstants.thrift. Nit: This change removes a bunch of commas in various comments. Maybe some extra commas got caught in a search-and-replace? http://gerrit.cloudera.org:8080/#/c/12543/5/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/12543/5/common/thrift/PlanNodes.thrift@75 PS5, Line 75: // A floating point number in range [0.0 1.0] that gives the probability of denying Same comma missing thing here and other comments in this file. -- To view, visit http://gerrit.cloudera.org:8080/12543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If215f16a636008757ceb439edbd6900a1be88c59 Gerrit-Change-Number: 12543 Gerrit-PatchSet: 5 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Feb 2019 22:09:42 +0000 Gerrit-HasComments: Yes
