Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 )
Change subject: Use `curl http://169.254.169.254/` to determine if we're running in aws ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12727/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/1/bin/bootstrap_system.sh@240 PS1, Line 240: http://169.254.169.254 > On second thought: we may need a stricter test for AWS if the goal is to de I'm not sure I would be able to properly test other non-ec2 cases. But that's outside the scope of what I'm trying to accomplish here. I'm happy to either: a) Re-implement using wget and timeout values. b) Abandon this for now and create a more robust version based on testing whether ntp endpoints are reachable I'm leaning towards a, lmk if you agree. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Mar 2019 23:26:24 +0000 Gerrit-HasComments: Yes
