Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 )
Change subject: Use `curl http://169.254.169.254/` to determine if we're running in aws ...................................................................... Patch Set 1: Code-Review+1 I don't want to block the change; otions 1 is a reasonable approach. In the worst case the code ends up choosing a suboptimal NTP server, but it would still be available -- even the Amazon NTP pool is reachable from outside their cloud. The main point is to keep the timeouts short, so the script does not block for a long time if run on a regular (non-cloud) machine. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Mar 2019 17:30:11 +0000 Gerrit-HasComments: No
