Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 )
Change subject: Clean up generation of XML configuration files ...................................................................... Patch Set 2: Thanks. I think for this case the "long lines" are probably a good idea for readability vs lots of weird breaking of long strings. I spent some time trying to see if I could disable the "long line" warning on flake8 for a single file, but just ended up finding some bikeshed github issue arguments about whether that's a good feature or not... and I gave up. Looks like we don't have a standard of "flake8 clean" so leaving these for now. -- To view, visit http://gerrit.cloudera.org:8080/12930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief4434d80baae0fd7be7ffe7b2e07bae1ac45e47 Gerrit-Change-Number: 12930 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Apr 2019 17:29:28 +0000 Gerrit-HasComments: No
