Hello Vihang Karajgaonkar, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, Adam Holley,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12930 to look at the new patch set (#3). Change subject: Clean up generation of XML configuration files ...................................................................... Clean up generation of XML configuration files hive-site.xml and sentry-site.xml in particular had grown multiple slightly-different variants, differing only in a few small pieces. This was difficult to maintain: in fact, while attempting to clean them up I found a number of places that the MySQL and Postgres versions of hive-site had diverged for no apparent reason. This moves away from using the sed-based templating for these configuration files, and instead uses python as a poor man's template system. That enables much simpler conditional logic. I briefly considered XSLT for this, but decided that Python is probably easier for the average developer to follow, modify, and debug. Along the way, I removed a few flags which appear to be no longer used by Hive 2 or later, and a few items which were already commented out in the previous template: - hive.stats.dbclass - hive.stats.dbconnectionstring - hive.stats.jdbcdriver These are no longer relevant after HIVE-12164 ("Remove jdbc stats collection mechanism") in Hive 2.0. - hive.metastore.rawstore.impl This has always defaulted to 'ObjectStore' in Hive, so there was no reason to set it explicitly. - test.log.dir - test.src.dir These were listed in the config in a commented-out section. These were commented out ever since 2012 when the file was first introduced. This also fixes the postgres URL to not include a misplaced ';create' parameter (which applies to Derby but not postgres). Change-Id: Ief4434d80baae0fd7be7ffe7b2e07bae1ac45e47 --- M bin/create-test-configuration.sh A bin/generate_xml_config.py M bin/jenkins/critique-gerrit-review.py A fe/src/test/resources/hive-site.xml.py D fe/src/test/resources/mysql-hive-site.xml.template D fe/src/test/resources/postgresql-hive-site.xml.cdp.template D fe/src/test/resources/postgresql-hive-site.xml.template A fe/src/test/resources/sentry-site.xml.py D fe/src/test/resources/sentry-site.xml.template D fe/src/test/resources/sentry-site_no_oo.xml.template D fe/src/test/resources/sentry-site_oo.xml.template D fe/src/test/resources/sentry-site_oo_nogrant.xml.template 12 files changed, 321 insertions(+), 998 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/12930/3 -- To view, visit http://gerrit.cloudera.org:8080/12930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ief4434d80baae0fd7be7ffe7b2e07bae1ac45e47 Gerrit-Change-Number: 12930 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>