Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12930 )
Change subject: Clean up generation of XML configuration files ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/12930/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12930/2//COMMIT_MSG@24 PS2, Line 24: the previous template. > Could you list the flags out? Just to make it easier to understand. I did a Done http://gerrit.cloudera.org:8080/#/c/12930/2//COMMIT_MSG@25 PS2, Line 25: > We should make sure to test on CentOS 6 since that still has python 2.6, ju tested it on an el6 box and it appears to work. http://gerrit.cloudera.org:8080/#/c/12930/2/bin/create-test-configuration.sh File bin/create-test-configuration.sh: http://gerrit.cloudera.org:8080/#/c/12930/2/bin/create-test-configuration.sh@32 PS2, Line 32: function generate_config { > It would be good to leave a comment here or below with thoughts about why g Done. Added a TODO for myself to convert over the remaining -site.xml files (hbase, ranger-admin) http://gerrit.cloudera.org:8080/#/c/12930/2/bin/generate_xml_config.py File bin/generate_xml_config.py: http://gerrit.cloudera.org:8080/#/c/12930/2/bin/generate_xml_config.py@80 PS2, Line 80: """ % dict(source_path=os.path.abspath(source_path)) > New-style formatting - .format(source_path=...) and {source_path} is genera Done http://gerrit.cloudera.org:8080/#/c/12930/2/bin/generate_xml_config.py@113 PS2, Line 113: os.unlink(tmp_path) > Does this delete the tmp file as well? yea, unlink = delete http://gerrit.cloudera.org:8080/#/c/12930/2/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/12930/2/fe/src/test/resources/hive-site.xml.py@69 PS2, Line 69: HBSE > (you don't need to fix it btw, just couldn't resist commenting) yea I actually wasted a few minutes because I accidentally fixed the typo and then some stuff broke :) It's set with this typo elsewhere. http://gerrit.cloudera.org:8080/#/c/12930/2/fe/src/test/resources/sentry-site.xml.py File fe/src/test/resources/sentry-site.xml.py: http://gerrit.cloudera.org:8080/#/c/12930/2/fe/src/test/resources/sentry-site.xml.py@49 PS2, Line 49: 'sentry.store.jdbc.url': 'jdbc:postgresql://localhost:5432/${SENTRY_POLICY_DB}/;create=true' > we should fix this JDBC URL: https://gerrit.cloudera.org/c/12894/3/fe/src/t Done -- To view, visit http://gerrit.cloudera.org:8080/12930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief4434d80baae0fd7be7ffe7b2e07bae1ac45e47 Gerrit-Change-Number: 12930 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Apr 2019 19:30:49 +0000 Gerrit-HasComments: Yes
