Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 )
Change subject: IMPALA-8363: fix e2e start with impala_log_dir ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12935/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12935/1//COMMIT_MSG@7 PS1, Line 7: fix e2e start with impala_log_dir nit: update the title to "Fix E2E start Impala cluster when impala_log_dir parameter is set"? http://gerrit.cloudera.org:8080/#/c/12935/1//COMMIT_MSG@16 PS1, Line 16: tests/authorization/test_ranger.py I think this file has nothing to do with the bug. Maybe mention that you manually updated this file to test the bug and verify the bug fix. -- To view, visit http://gerrit.cloudera.org:8080/12935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f46f40474b4b380abe88647a37e8e4d2231d745 Gerrit-Change-Number: 12935 Gerrit-PatchSet: 1 Gerrit-Owner: radford nguyen <radford.ngu...@gmail.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Thu, 04 Apr 2019 23:08:46 +0000 Gerrit-HasComments: Yes