radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 )
Change subject: IMPALA-8363: Fix E2E start with impala_log_dir ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12935/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/12935/1/tests/common/custom_cluster_test_suite.py@147 PS1, Line 147: kwargs = { : "cluster_size": cluster_size, : "num_coordinators": cluster_size, : "expected_num_executors": cluster_size, : "default_query_options": method.func_dict.get(DEFAULT_QUERY_OPTIONS) : } : if IMPALA_LOG_DIR in method.func_dict: : kwargs["impala_log_dir"] = method.func_dict[IMPALA_LOG_DIR] : self._start_impala_cluster(cluster_args, **kwargs) : super(CustomClusterTestSuite, self).setup_ > Agree with Fredy. Could also do something clever with kwargs, e.g. I think the kwargs approach is better because then `start_impala_cluster` can still be "in charge" of defaulting the `impala_log_dir` option -- To view, visit http://gerrit.cloudera.org:8080/12935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f46f40474b4b380abe88647a37e8e4d2231d745 Gerrit-Change-Number: 12935 Gerrit-PatchSet: 2 Gerrit-Owner: radford nguyen <radford.ngu...@gmail.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Thu, 11 Apr 2019 04:27:06 +0000 Gerrit-HasComments: Yes
