Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12935 )
Change subject: IMPALA-8363: fix e2e start with impala_log_dir ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12935/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/12935/1/tests/common/custom_cluster_test_suite.py@147 PS1, Line 147: if IMPALA_LOG_DIR in method.func_dict: : self._start_impala_cluster(cluster_args, : default_query_options=method.func_dict.get(DEFAULT_QUERY_OPTIONS), : impala_log_dir=method.func_dict[IMPALA_LOG_DIR], cluster_size=cluster_size, : num_coordinators=cluster_size, expected_num_executors=cluster_size) : else: : self._start_impala_cluster(cluster_args, : default_query_options=method.func_dict.get(DEFAULT_QUERY_OPTIONS), : cluster_size=cluster_size, num_coordinators=cluster_size, : expected_num_executors=cluster_size) i think this code may end up getting inconsistent if add more parameter. Maybe we should keep a single call instead. DEFAULT_IMPALA_LOG_DIR = os.getenv('LOG_DIR', "/tmp/") impala_log_dir = method.func_dict[IMPALA_LOG_DIR] if IMPALA_LOG_DIR else DEFAULT_IMPALA_LOG_DIR self._start_impala_cluster(cluster_args, default_query_options=method.func_dict.get(DEFAULT_QUERY_OPTIONS), impala_log_dir=impala_log_dir, cluster_size=cluster_size, num_coordinators=cluster_size, expected_num_executors=cluster_size) -- To view, visit http://gerrit.cloudera.org:8080/12935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f46f40474b4b380abe88647a37e8e4d2231d745 Gerrit-Change-Number: 12935 Gerrit-PatchSet: 1 Gerrit-Owner: radford nguyen <radford.ngu...@gmail.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: radford nguyen <radford.ngu...@gmail.com> Gerrit-Comment-Date: Thu, 04 Apr 2019 23:33:48 +0000 Gerrit-HasComments: Yes
