Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 )
Change subject: IMPALA-7981: Add host disk statistics to profile ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12822/4/be/src/util/system-state-info.h File be/src/util/system-state-info.h: http://gerrit.cloudera.org:8080/#/c/12822/4/be/src/util/system-state-info.h@255 PS4, Line 255: for (int i = 0; i < num_values; ++i) { : int64_t v = -1; : (*ss) >> v; Do you plan to choose https://gerrit.cloudera.org/#/c/12954/2/be/src/util/system-state-info.cc@169 over the current implementation ? http://gerrit.cloudera.org:8080/#/c/12822/2/be/src/util/system-state-info.h File be/src/util/system-state-info.h: http://gerrit.cloudera.org:8080/#/c/12822/2/be/src/util/system-state-info.h@183 PS2, Line 183: /// The enum names correspond to the fields of /proc/diskstats : /// https://www.kernel.org/doc/Documentation/iostats.txt > These are the fields present in 2.6, while 4.8 added more fields that we're Yes, I think the link to the doc should be sufficient. -- To view, visit http://gerrit.cloudera.org:8080/12822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373e7da47a0d722938e6ca1572c49a502951ed57 Gerrit-Change-Number: 12822 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Apr 2019 20:56:43 +0000 Gerrit-HasComments: Yes
