Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 )
Change subject: IMPALA-7981: Add host disk statistics to profile ...................................................................... Patch Set 6: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/12822/6/be/src/util/system-state-info.cc File be/src/util/system-state-info.cc: http://gerrit.cloudera.org:8080/#/c/12822/6/be/src/util/system-state-info.cc@57 PS6, Line 57: num_values nit: expected_num_values http://gerrit.cloudera.org:8080/#/c/12822/6/be/src/util/system-state-info.cc@110 PS6, Line 110: : nit: unnecessary blank lines. http://gerrit.cloudera.org:8080/#/c/12822/6/be/src/util/system-state-info.cc@129 PS6, Line 129: stat_string Does it make sense to DCHECK(StringPiece(stat_string).starts_with('cpu ')); ? -- To view, visit http://gerrit.cloudera.org:8080/12822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373e7da47a0d722938e6ca1572c49a502951ed57 Gerrit-Change-Number: 12822 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Apr 2019 19:10:44 +0000 Gerrit-HasComments: Yes
