Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 )
Change subject: IMPALA-7981: Add host disk statistics to profile ...................................................................... Patch Set 6: (1 comment) Rebased the change and made the overall code a bit more consistent. Please see PS6. http://gerrit.cloudera.org:8080/#/c/12822/4/be/src/util/system-state-info.h File be/src/util/system-state-info.h: http://gerrit.cloudera.org:8080/#/c/12822/4/be/src/util/system-state-info.h@255 PS4, Line 255: : : > On the other hand, this one uses standard c++ stringstreams so it might be Went with stringpieces and moved this to an anonymous namespace in the .cc file. -- To view, visit http://gerrit.cloudera.org:8080/12822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I373e7da47a0d722938e6ca1572c49a502951ed57 Gerrit-Change-Number: 12822 Gerrit-PatchSet: 6 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Apr 2019 19:03:49 +0000 Gerrit-HasComments: Yes
