Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13508 )

Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13508/1//COMMIT_MSG@7
PS1, Line 7: NPE
nit: might worth spell it out at least once.


http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:

http://gerrit.cloudera.org:8080/#/c/13508/1/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@124
PS1, Line 124:       analyzer.addAccessEvent(new TAccessEvent(
Should we log the exception?



--
To view, visit http://gerrit.cloudera.org:8080/13508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952
Gerrit-Change-Number: 13508
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 13:56:49 +0000
Gerrit-HasComments: Yes

Reply via email to