Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/13508 )
Change subject: IMPALA-8612: Fix sporadic NPE when dropping an authorized table ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java: http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@40 PS3, Line 40: Drop > Shouldn't this be DropTableOrViewStmt? Oh, copy-paste issue. Thanks for spotting! Done http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@131 PS3, Line 131: "Ignoring TableLoadingException for {}", tableName_.toString()); > nit: it's usually preferable to use the SLF4J log format, e.g. LOG.info("Ig Done http://gerrit.cloudera.org:8080/#/c/13508/3/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@134 PS3, Line 134: ring()); > tableName_.toString() may print "db.tbl": https://github.com/apache/impala/ If you drop the table like "drop table tbl;" then tableName_.toString() won't print "default.tbl" just "tbl". However, providing default as the DB name for the drop table statement will result in printing "default.tbl". I think this is fine and I rewrote the code to use TableName.toString(). Done -- To view, visit http://gerrit.cloudera.org:8080/13508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70bd7ca4796b24920ee156436bf8bbc682e7d952 Gerrit-Change-Number: 13508 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Jun 2019 14:07:27 +0000 Gerrit-HasComments: Yes
