Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 )
Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/13807/18/be/src/util/bit-packing.inline.h File be/src/util/bit-packing.inline.h: http://gerrit.cloudera.org:8080/#/c/13807/18/be/src/util/bit-packing.inline.h@268 PS18, Line 268: DCHECK_GE(in_bytes, BYTES_TO_READ_IN_BATCH * batches_to_read); It should be DCHECK_GE(in_bytes, BYTES_TO_READ_IN_BATCH * batches_to_read). http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py File be/src/util/vectorised_bit_unpacking_generator.py: http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py@76 PS19, Line 76: from abc import ABCMeta, abstractmethod, abstractproperty > flake8: F401 'abc.ABCMeta' imported but unused Removed metaclass inheritance, so I'm going to remove this. http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py@89 PS19, Line 89: from typing import List, Optional, Tuple > flake8: F401 'typing.Tuple' imported but unused The unused imports are used by mypy, a static type checker I like to use. If this is a problem I can remove the imports and add them when I'd like to use mypy, but if they can stay it's better for me. -- To view, visit http://gerrit.cloudera.org:8080/13807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947 Gerrit-Change-Number: 13807 Gerrit-PatchSet: 20 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Jul 2019 18:48:50 +0000 Gerrit-HasComments: Yes
