Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 )
Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation ...................................................................... Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py File be/src/util/vectorised_bit_unpacking_generator.py: http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py@76 PS19, Line 76: > Removed metaclass inheritance, so I'm going to remove this. Accidentally I found a way to use abstract base classes without the metaclass syntax, I should have just looked at the abc module documentation. I simply derive the class from ABC instead of using ABCMeta as a metaclass. This way flake8 has no problem with it. http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py@89 PS19, Line 89: > Yeah we can ignore this, it will only get re-flagged if someone touches the I added a comment describing why we have those imports. -- To view, visit http://gerrit.cloudera.org:8080/13807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947 Gerrit-Change-Number: 13807 Gerrit-PatchSet: 21 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Jul 2019 08:03:22 +0000 Gerrit-HasComments: Yes
