Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13807 )
Change subject: IMPALA-8741: Speed up bit unpacking by vectorisation ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py File be/src/util/vectorised_bit_unpacking_generator.py: http://gerrit.cloudera.org:8080/#/c/13807/19/be/src/util/vectorised_bit_unpacking_generator.py@89 PS19, Line 89: from typing import List, Optional, Tuple > The unused imports are used by mypy, a static type checker I like to use. I Yeah we can ignore this, it will only get re-flagged if someone touches these lines in a new patchset. There's a reason these are just comments rather than a hard failure - there are false positives. If you want to tweak bin/jenkins/critique-gerrit-review.py to ignore this special case, feel free. -- To view, visit http://gerrit.cloudera.org:8080/13807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e452a547973778bbd8d768c608e1a32e948f947 Gerrit-Change-Number: 13807 Gerrit-PatchSet: 19 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Jul 2019 19:12:05 +0000 Gerrit-HasComments: Yes